Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge jdk:jdk-25+1 #206

Open
wants to merge 4 commits into
base: crac
Choose a base branch
from
Open

Merge jdk:jdk-25+1 #206

wants to merge 4 commits into from

Conversation

dimitryc
Copy link
Contributor

@dimitryc dimitryc commented Feb 25, 2025

Merge jdk:jdk-25+1

No conflicts
commit c4f2413b5dff7765f8b3baffbaadced0eea9c04f (HEAD -> merge-jdk, dmitry-crac/merge-jdk)
Merge: 884d0746b16 bedb68aba12
Author: Dmitry Cherepanov <[email protected]>
Date:   Tue Feb 25 12:00:43 2025 +0400

    Merge jdk:jdk-25+1

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/206/head:pull/206
$ git checkout pull/206

Update a local copy of the PR:
$ git checkout pull/206
$ git pull https://git.openjdk.org/crac.git pull/206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 206

View PR using the GUI difftool:
$ git pr show -t 206

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/206.diff

Using Webrev

Link to Webrev Comment

Pavel Rappo and others added 4 commits December 5, 2024 17:03
8342982: Add SourceVersion.RELEASE_25
8342983: Add source 25 and target 25 to javac

Co-authored-by: Joe Darcy <[email protected]>
Reviewed-by: iris, darcy, erikj, dholmes
Reviewed-by: tschatzl, ayang, iwalulya, zgu
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2025

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 25, 2025

@dimitryc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge jdk:jdk-25+1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the crac branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 25, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 25, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant